Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appender): size-based rotation #2497

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(appender): size-based rotation #2497

wants to merge 6 commits into from

Commits on Feb 13, 2024

  1. feat(appender): size-based rotation 

    This patch adds size-based rotation to tracing-appender.

In a constraint environment, we should be able to contain the logging
size and period.

Related issues:
- tokio-rs#1940
- tokio-rs#858
    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    07d9a2a View commit details
    Browse the repository at this point in the history

  2. Code review

    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8704565 View commit details
    Browse the repository at this point in the history

  3. Format date according to Timed and do not create too many files 

    Follow the date format induced by the selected `Timed`. An index
is inserted into the file name so we can rotate when the max size is
reached. Also, when the most recent file does not exceed the max size,
we simply reuse it instead of creating yet another file.
    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    81d2d70 View commit details
    Browse the repository at this point in the history

  4. Code review 2

    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    08eae52 View commit details
    Browse the repository at this point in the history

  5. Harden size-based rotation test (use a constant OffsetDateTime)

    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    617c289 View commit details
    Browse the repository at this point in the history

  6. Refactor advance_date_and_index a bit

    @CBenoit
    CBenoit committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    717ced1 View commit details
    Browse the repository at this point in the history