Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: Replace horrible handwritten parser with a regex #25

Merged
merged 2 commits into from
Mar 8, 2019
Merged

fmt: Replace horrible handwritten parser with a regex #25

merged 2 commits into from
Mar 8, 2019

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Mar 8, 2019

Signed-off-by: Eliza Weisman eliza@buoyant.io

@hawkw
fmt: Replace horrible handwritten parser with a regex
e1b53f6 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw added the crate/fmt Related to the `tracing-fmt` crate label Mar 8, 2019
@hawkw hawkw self-assigned this Mar 8, 2019
@hawkw hawkw requested a review from LucioFranco March 8, 2019 20:10
LucioFranco
LucioFranco approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LucioFranco LucioFranco mentioned this pull request Mar 8, 2019
Closed
@hawkw hawkw merged commit c46a4bd into master Mar 8, 2019
@hawkw hawkw deleted the eliza/fmt-filter-regex branch March 8, 2019 21:10
@hawkw hawkw mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees

@hawkw hawkw

Labels
crate/fmt Related to the `tracing-fmt` crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkw @LucioFranco