tracing, tracing-futures: instrument futures with Spans in Drop #2561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2541
Motivation
See #2541
Solution
Wrap
Instrumented::inner
(both intracing
andtracing-futures
) intoOption
.Pin::set
it toNone
in thePinnedDrop
impl
to drop the future in the context of aSpan
that we enter in the said impl.This implementation uses
Option::unwrap_unchecked
in places where we need to extractinner
future, as the only time we set it toNone
is inDrop
, or in a method which takesInstrumented
by value, guaranteeing that there is no case for UB.Alternative was to use
ManuallyDrop
, but I don't think we canFuture::poll
Pin<&mut ManuallyDrop<T>>
easily?