Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing, tracing-futures: instrument Future inside Drop #2562

Merged
merged 14 commits into from
Apr 18, 2023

Commits on Apr 14, 2023

  1. Instrument Future inside Drop

    ilslv committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f0cc5d1 View commit details
    Browse the repository at this point in the history
  2. subscriber: add ability to disable ANSI without crate feature (tokio-…

    …rs#2532)
    
    ## Motivation
    
    Currently it is not possible to disable ANSI in `fmt::Subscriber`
    without enabling the "ansi" crate feature. This makes it difficult for
    users to implement interoperable settings that are controllable with
    crate features without having to pull in the dependencies "ansi" does.
    
    I hit this while writing an application with multiple logging options
    set during compile-time and I wanted to cut down on dependencies if
    possible.
    
    ## Solution
    
    This changes `fmt::Subscriber::with_ansi()` to not require the "ansi"
    feature flag. This way, `with_ansi(false)` can be called even when the
    "ansi" feature is disabled. Calling `with_ansi(true)` when the "ansi"
    feature is not enabled will panic in debug mode, or print a warning if
    debug assertions are disabled.
    
    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    daxpedda and hawkw committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1cb523b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Review corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a0b5166 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38620f6 View commit details
    Browse the repository at this point in the history
  3. Corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    abcb488 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    41c10bd View commit details
    Browse the repository at this point in the history
  5. Corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e1d6d4e View commit details
    Browse the repository at this point in the history
  6. Instrument Future inside Drop

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    813bd3e View commit details
    Browse the repository at this point in the history
  7. Review corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b961057 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b24f383 View commit details
    Browse the repository at this point in the history
  9. Corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    daf27b5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    95f4ed7 View commit details
    Browse the repository at this point in the history
  11. Corrections

    ilslv committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c8b56a8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    73e73a9 View commit details
    Browse the repository at this point in the history