-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare tracing-log 0.2.0 #2772
Conversation
f1184b9
to
5d913c4
Compare
6c110bd
to
d018fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple tiny nits
tracing-log/CHANGELOG.md
Outdated
This release contains two breaking changes: the removal of the `env_logger` | ||
and `trace_logger` features. Below are the suggested migration paths: | ||
|
||
- `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] | ||
or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] | ||
filters instead. | ||
- `trace_logger`: users should use the `tracing` crate's "log" feature flag instead. | ||
|
||
### Breaking Changes | ||
|
||
- Remove `env_logger` feature ([#2771]) | ||
- Remove `trace_logger` feature ([#2771]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we maybe mention somewhere in here that env_logger
was removed as part of mitigation for a RustSec advisory?
tracing-log/CHANGELOG.md
Outdated
- `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] | ||
or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] | ||
filters instead. | ||
- `trace_logger`: users should use the `tracing` crate's "log" feature flag instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we link to the tracing
crate docs discussing this feature?
@@ -1,3 +1,24 @@ | |||
# 0.2.0 (October 23rd, 2023) | |||
|
|||
This release contains two breaking changes: the removal of the `env_logger` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we maybe mention that they were already deprecated in 0.1.x?
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
will address the nits after dinner, if that's okay! |
i just went ahead and did it, hope that's okay! |
# 0.3.18 (November 13, 2023) This release of `tracing-subscriber` adds support for the [`NO_COLOR`] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ### Added - **chrono**: Add [`chrono`] implementations of `FormatTime` ([#2690]) - **subscriber**: Add support for the [`NO_COLOR`] environment variable in `fmt::Layer` ([#2647]) - **fmt**: make `format::Writer::new()` public ([#2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([#2407]) ### Changed - **log**: bump version of `tracing-log` to 0.2 ([#2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://github.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [#2690]: #2690 [#2647]: #2647 [#2680]: #2680 [#2407]: #2407 [#2772]: #2772 Thanks to @shayne-fletcher, @dmlary, @kaifastromai, and @jsgf for contributing!
# 0.3.18 (November 13, 2023) This release of `tracing-subscriber` adds support for the [`NO_COLOR`] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ### Added - **chrono**: Add [`chrono`] implementations of `FormatTime` ([tokio-rs#2690]) - **subscriber**: Add support for the [`NO_COLOR`] environment variable in `fmt::Layer` ([tokio-rs#2647]) - **fmt**: make `format::Writer::new()` public ([tokio-rs#2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([tokio-rs#2407]) ### Changed - **log**: bump version of `tracing-log` to 0.2 ([tokio-rs#2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://github.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [tokio-rs#2690]: tokio-rs#2690 [tokio-rs#2647]: tokio-rs#2647 [tokio-rs#2680]: tokio-rs#2680 [tokio-rs#2407]: tokio-rs#2407 [tokio-rs#2772]: tokio-rs#2772 Thanks to @shayne-fletcher, @dmlary, @kaifastromai, and @jsgf for contributing!
# 0.2.0 (October 24th, 2023) This release contains two breaking changes: the removal of the `env_logger` and `trace_logger` features. Below are the suggested migration paths: - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] filters instead. - `trace_logger`: users should use the `tracing` crate's ["log" feature flag][log-feature] instead. ### Breaking Changes - Remove deprecated `env_logger` feature. This removes the dependency on the unmaintained `atty` crate, resolving the security advisory [GHSA-g98v-hv3f-hcfr]/[RUSTSEC-2021-0145]. ([tokio-rs#2771]) - Remove deprecated `trace_logger` feature. ([tokio-rs#2771]) [tokio-rs#2771]: tokio-rs#2771 [`tracing_subscriber::fmt::Subscriber`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Subscriber.html [`tracing_subscriber::fmt::Layer`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Layer.html [`Targets`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/targets/struct.Targets.html [`EnvFilter`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html [log-feature]: https://docs.rs/tracing/latest/tracing/#emitting-log-records [GHSA-g98v-hv3f-hcfr]: GHSA-g98v-hv3f-hcfr [RUSTSEC-2021-0145]: https://rustsec.org/advisories/RUSTSEC-2021-0145.html
# 0.3.18 (November 13, 2023) This release of `tracing-subscriber` adds support for the [`NO_COLOR`] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ### Added - **chrono**: Add [`chrono`] implementations of `FormatTime` ([tokio-rs#2690]) - **subscriber**: Add support for the [`NO_COLOR`] environment variable in `fmt::Layer` ([tokio-rs#2647]) - **fmt**: make `format::Writer::new()` public ([tokio-rs#2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([tokio-rs#2407]) ### Changed - **log**: bump version of `tracing-log` to 0.2 ([tokio-rs#2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://github.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [tokio-rs#2690]: tokio-rs#2690 [tokio-rs#2647]: tokio-rs#2647 [tokio-rs#2680]: tokio-rs#2680 [tokio-rs#2407]: tokio-rs#2407 [tokio-rs#2772]: tokio-rs#2772 Thanks to @shayne-fletcher, @dmlary, @kaifastromai, and @jsgf for contributing!
This branch prepares a release of
tracing-log 0.2.0
. The sole breaking changeis the removal of the
env_logger
feature. Please refer to #2771 and #2750for the context behind this decision.
(Note that this branch depends on #2770 and #2771. I will rebase this branch to
catch changes that exist on v0.1.x when those branches land.)