chore: fixes for clippy changes in Rust 1.74 #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of Rust 1.74, there are some new or modified clippy lints that need adaption in the code. The main change was the removal of the `private_in_public`. https://rust-lang.github.io/rfcs/2145-type-privacy.html Then two more changes were required, in one case to adhere a lint and the other to allow it. When talking about what an "application" needs to do when setting up `tracing-error`, it makes sense to include `fn main()` in the doctest, even though the lint recommends against it.
hds
requested review from
a team,
yaahc,
hawkw,
carllerche and
davidbarsky
as code owners
davidbarsky
approved these changes
Nov 26, 2023
hawkw
pushed a commit
that referenced
this pull request
Mar 1, 2024
With the release of Rust 1.74, there are some new or modified clippy lints that need adaption in the code. The main change was the removal of the `private_in_public`. https://rust-lang.github.io/rfcs/2145-type-privacy.html Then two more changes were required, in one case to adhere a lint and the other to allow it. When talking about what an "application" needs to do when setting up `tracing-error`, it makes sense to include `fn main()` in the doctest, even though the lint recommends against it. ; Conflicts: ; examples/examples/map-traced-error.rs
davidbarsky
pushed a commit
that referenced
this pull request
Oct 2, 2024
With the release of Rust 1.74, there are some new or modified clippy lints that need adaption in the code. The main change was the removal of the `private_in_public`. https://rust-lang.github.io/rfcs/2145-type-privacy.html Then two more changes were required, in one case to adhere a lint and the other to allow it. When talking about what an "application" needs to do when setting up `tracing-error`, it makes sense to include `fn main()` in the doctest, even though the lint recommends against it. ; Conflicts: ; examples/examples/map-traced-error.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the release of Rust 1.74, there are some new or modified clippy
lints that need adaption in the code.
Solution
The main change was the removal of the
private_in_public.https://rust-lang.github.io/rfcs/2145-type-privacy.html
Then two more changes were required, in one case to adhere a lint and
the other to allow it. When talking about what an "application" needs to
do when setting up
tracing-error, it makes sense to includefn main()in the doctest, even though the lint recommends against it.