Change order of async and unsafe modifiers in instrument procmacro
#2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: tokio-rs#2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
hawkw
approved these changes
Jan 26, 2024
|
warnings job failure is unrelated, let's fix that separately: https://github.com/tokio-rs/tracing/actions/runs/7668345432/job/20899985659#step:4:1 |
kaffarell
added a commit
to kaffarell/tracing
that referenced
this pull request
Feb 14, 2024
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: tokio-rs#2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
|
@hawkw had a look at the job failure and it seems like the Footnotes |
|
I could already go ahead and add it so that we won't forget? It will only return a |
|
Please do! Thank you! |
|
Opened it: #2886! |
kaffarell
added a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: tokio-rs#2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
davidbarsky
pushed a commit
that referenced
this pull request
Oct 2, 2024
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: #2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
davidbarsky
pushed a commit
that referenced
this pull request
Oct 2, 2024
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: #2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
davidbarsky
pushed a commit
that referenced
this pull request
Oct 2, 2024
When using `#[tracing::instrument]` and the `async unsafe` modifiers the generated function read `unsafe async fn`, which is wrong. Corrected the order and added a test. Fixes: #2576 Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
#[tracing::instrument]and theasync unsafemodifiers the generated function readunsafe async fn, which is wrong. Corrected the order and added a test.Fixes: #2576