Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tracing-attributes] Support for using #[instrument] with async-trait #711

Merged
merged 4 commits into from
May 13, 2020
Merged

[tracing-attributes] Support for using #[instrument] with async-trait #711

merged 4 commits into from
May 13, 2020

Commits on May 10, 2020

  1. [tracing-attributes] Add support for using #[instrument] with async-t… 

    …rait

* Rewrite the block when it looks like there is async_trait involved to wrap the internal async function instead of the
  wrapper generated by asyc-trait
* Rewrite '_self' as 'self' when using #[instrument] jointly with async-trait
* Add somes tests
* Remove the mention that async-trait is not supported with tracing
    @nightmared
    nightmared committed May 10, 2020
    Configuration menu
    Copy the full SHA
    58f7027 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. improve readability and tests

    @nightmared
    nightmared committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9b07f86 View commit details
    Browse the repository at this point in the history

  2. fixes, part. 2

    @nightmared
    nightmared committed May 13, 2020
    Configuration menu
    Copy the full SHA
    f54465d View commit details
    Browse the repository at this point in the history

  3. reflow comments

    @nightmared
    nightmared committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d5f7d72 View commit details
    Browse the repository at this point in the history