subscriber: disable regex dependency default features #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex dependency is used only to parse configuration directives, and therefore is not performance critical. This change turns off all default features (except 'std') from regex in order to optimize for compile times for this non-performance-critical code. Note that due to the presence of the 'criterion' dependency (which has its own default-features dependency on regex), the tests do not normally run with only the minimal set of regex features. I did remove the criterion dependency to verify that tests build, but I'm not sure how to test that we're not using disabled regex features on an ongoing basis.
This is probably not a problem, as long as downstream users don't have to compile those features. It's fine to enable them just when compiling tests, as the dependency tree is likely much shallower anyway. |
hawkw
approved these changes
Aug 7, 2020
hawkw
added a commit
that referenced
this pull request
Aug 11, 2020
Fixed - **env-filter**: Incorrect max level hint when filters involving span field values are in use (#907) - **registry**: Fixed inconsistent span stacks when multiple registries are in use on the same thread (#901) Changed - **env-filter**: `regex` dependency enables fewer unused feature flags (#899) Thanks to @bdonlan and @jeromegn for contributing to this release!
hawkw
added a commit
that referenced
this pull request
Aug 11, 2020
### Fixed - **env-filter**: Incorrect max level hint when filters involving span field values are in use (#907) - **registry**: Fixed inconsistent span stacks when multiple registries are in use on the same thread (#901) ### Changed - **env-filter**: `regex` dependency enables fewer unused feature flags (#899) Thanks to @bdonlan and @jeromegn for contributing to this release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex dependency is used only to parse configuration directives, and
therefore is not performance critical. This change turns off all default
features (except 'std') from regex in order to optimize for compile times for
this non-performance-critical code.
Note that due to the presence of the 'criterion' dependency (which has its own
default-features dependency on regex), the tests do not normally run with only
the minimal set of regex features. I did remove the criterion dependency to
verify that tests build, but I'm not sure how to test that we're not using
disabled regex features on an ongoing basis.
Motivation
Solution