Skip to content

Commit

Permalink
fix: UI project cannot handle fallback routes (feast-dev#3766)
Browse files Browse the repository at this point in the history
* fix: fallback route cannot navigate to react page

Signed-off-by: snowron <snowronark@gmail.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>

* refactor fix

Signed-off-by: snowron <snowronark@gmail.com>

---------

Signed-off-by: snowron <snowronark@gmail.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
snowron committed Oct 11, 2023
1 parent 470f6a8 commit 96ece0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/feast/ui_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def read_registry():
# For all other paths (such as paths that would otherwise be handled by react router), pass to React
@app.api_route("/p/{path_name:path}", methods=["GET"])
def catch_all():
filename = ui_dir + "index.html"
filename = ui_dir.joinpath("index.html")

with open(filename) as f:
content = f.read()
Expand Down

0 comments on commit 96ece0f

Please sign in to comment.