Implement ViewStore #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityadaniel
requested review from
jeffersonsetiawan and
wendyliga
as code owners
Comment on lines
356
to
373
| /// Initializes a structure that transforms a store into an observable view store in order to | ||
| /// compute views from store state. | ||
| /// | ||
| /// > Warning: This initializer is deprecated. Use | ||
| /// ``WithViewStore/init(_:observe:removeDuplicates:content:file:line:)`` to make state | ||
| /// observation explicit. | ||
| /// > | ||
| /// > When using ``WithViewStore`` you should take care to observe only the pieces of state that | ||
| /// your view needs to do its job, especially towards the root of the application. See | ||
| /// <doc:Performance> for more details. | ||
| /// | ||
| /// - Parameters: | ||
| /// - store: A store. | ||
| /// - isDuplicate: A function to determine when two `ViewState` values are equal. When values | ||
| /// are equal, repeat view computations are removed. | ||
| /// - content: A function that can generate content from a view store. | ||
| @available( | ||
| iOS, |
There was a problem hiding this comment.
I think we can remove all deprecated things here, as this is new for RxTCA, wdyt?
wendyliga
approved these changes
Aug 4, 2023
jeffersonsetiawan
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ViewStore for SwiftUI compatibility