Support no gopackage #101
Merged
Support no gopackage #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
append the go_package automatically using fix_gopackage.sh.
move deep/bar under bar. remove pb.go here since it should be generated under protogen/
jekiapp
force-pushed
the
support_no_gopackage
branch
from
ba944ca to
dfe4706
Compare
|
This looks great @jekiapp 👍 . Only thought I have is that the container size is pretty big and I thought it would be nice to try and move towards using a scratch container. If thats to happen we'd need to absorb the bash script's behaviour into the binary, but I'd push that into the future. I'm looking forward to this one being released so we can get back onto latest. |
|
@HairyMike Let me create the PR to master first to update the Readme, so that people use the beta build and test it before I merge this changes to latest. |
|
After I build the image and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current version of gripmock is requiring a declaration of
option go_package. Thus I expect many issues since the user of gripmock is not always a Golang user.Technically, these changes are not making gripmock able to run without
option go_package, but it will generate the declaration of it based on the.protofiles provided. Since it only uses a simple bash script to do that, I will release this version as a beta release before making a stable release.Changelist
fix_gopackage.shis the core change here, it will insert the go_package declaration if none of the provided.protoshas it. If one of them has it, it will return, if all of the files have it then will be skipped.example/no-gopackagewill provided an example also a test for this new feature.