Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

fix: change alias path #33

Merged

Conversation

afifkhaidir-tkpd
Copy link

@afifkhaidir-tkpd afifkhaidir-tkpd commented Jun 18, 2019

Eslint failed to find alias.js file if we open the project in the editor from the outer folder.

Given this project structure:

projects
├── project A
│   ├── node_modules
│   │   ├── eslint-config-treats
│   │   ├── treats

alias returning ~/projects/node_modules/treats/alias instead of ~/projects/project A/node_modules/treats/alias.

Isn't it better to find the file relative to its package folder?

@afifkhaidir-tkpd afifkhaidir-tkpd added the bug Something isn't working label Jun 18, 2019
@afifkhaidir-tkpd afifkhaidir-tkpd changed the title fix: change alias route fix: change alias path Jun 18, 2019
@martinock martinock merged commit 891ec44 into tokopedia:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants