Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '=' key for zooming in #18

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Add '=' key for zooming in #18

merged 2 commits into from
Feb 18, 2023

Conversation

mlochen
Copy link
Collaborator

@mlochen mlochen commented Feb 18, 2023

Commit message says it all :)

Copy link
Owner

@tom-mohr tom-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Also nice that you changed the shortcuts overview accordingly. Please just merge the two redundant cases of the enhanced switch by using the comma.

@@ -902,6 +903,7 @@ protected void onKeyPressed(String keyName) {
case "s" -> shaders.stepForward();
case "S" -> shaders.stepBackward();
case "+" -> zoomGoal *= Math.pow(zoomStepFactor, 2);// more steps than when scrolling
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case "+" -> zoomGoal *= Math.pow(zoomStepFactor, 2);// more steps than when scrolling
case "+", "=" -> zoomGoal *= Math.pow(zoomStepFactor, 2);// more steps than when scrolling

@mlochen mlochen requested a review from tom-mohr February 18, 2023 18:18
Copy link
Owner

@tom-mohr tom-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the work! ;)

@tom-mohr tom-mohr merged commit da3e631 into tom-mohr:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants