Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Control Options #26

Merged
merged 6 commits into from
May 5, 2022
Merged

Conversation

tom-writes-code
Copy link
Owner

Allow users to edit the control options they see on screen

Work in progress:
image

I think I'd like a new table to go with this to set:

  • A firmwide default set of control options
  • An individual user default set of control options
  • Specific control options for a single snippet

Allow users to edit the control options they see on screen
@tom-writes-code tom-writes-code added the enhancement New feature or request label Apr 21, 2022
@tom-writes-code tom-writes-code self-assigned this Apr 21, 2022
@tom-writes-code tom-writes-code linked an issue Apr 21, 2022 that may be closed by this pull request
@tom-writes-code
Copy link
Owner Author

tom-writes-code commented Apr 26, 2022

This needs documenting and properly testing in anger before I merge it.

A fallback control statement of ctl-opt; is provided
image

Users can override this system default for a single snippet
image

Users can also override this system default and save that as their personal default
image

Whenever a repl session is loaded, then a control statement is found by checking in the following order:

  1. Is there already a control statement linked to this session?
  2. Is there a user default control statement?
  3. Is there a system default control statement?
  4. Return ctl-opt;
  • I intentionally haven't provided a way of setting the system/organisational default, but I will provide documentation instructions.
  • I need to test how this works with saving and loading snippets

There is also no method of removing your user default for good. This feels like a niche requirement at the moment.

@tom-writes-code
Copy link
Owner Author

The generated source puts the ctl-opt statements in a predictable location
image

Fix UNSIGNED/UNS parsing error
@tom-writes-code tom-writes-code merged commit e26227a into main May 5, 2022
@tom-writes-code tom-writes-code deleted the allow-changes-to-ctl-opt branch May 5, 2022 15:15
martintosney pushed a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use a binding directory, or any other ctl-opt statements
1 participant