-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging wonderful changes from @justinrusso, with some updates #14
Conversation
Cleans up the args of the method
Happy you liked it!
This is not necessary but thank you for the offer
This has seemed OK so far in practice. I do use an auto-generate timer and after a few days I do end up getting an error thrown but I believe it is unrelated. Have not had time to look into it. It might be good to make it a setting. Maybe something like |
Pull request overview:
Improved README - removed troublesome HTML tags, improved readability, and added new fields in settings.
Added
BotOwner
field - gives developer (or whichever user is specified here) the permission to bypass the cooldown, or use the generate command even when the command is disabled.Added
ShouldWhisper
field - whether the Bot should whisper the cooldown message. Otherwise, do not send the cooldown.WhisperCooldown
.ShouldWhisper
might confuse users, who believe that it means the generated output is whispered.Modified default outputs slightly (e.g. after using
!enable
).Added
EnableGenerateCommand
field - enables or disables!generate
. Broadcaster can override this setting, and still generate.!generate
. Note: When the Bot is disabled through!disable
, then nobody can use it. This still allows the broadcaster to prevent people from using it. (Edit: I see now that this is already done by you, as I see now that you updatedself.check_if_streamer
. I'll rename this method to something clearer instead.)Added
.gitignore
.settings.txt
(nowsettings.json
) in the.gitignore.
However, I do want to ensure that a correct samplesettings.json
is pushed to GitHub, allowing users to see what the file should look like, before running the program.Renamed
settings.txt
withsettings.json
.Settings
class to include an automatic update, which reads the oldsettings.txt
, adds the default values of the new fields, writes it tosettings.json
, and removessettings.txt
.Added typing to parameters in methods.
Start a second sentence if the generated sentence is too short, uses a new
MinSentenceWordAmount
value in settings.json.Set the default help Timer to once every 5 hours, instead of off.
Ensure the README is correct, with the new changes.
@justinrusso
First of all, thank you! I really like the direction they went, and I'd love to take some of the changes one step further, as described by the boxes.
I'll work on these myself, though your help is definitely appreciated. For the time being, I'd really love to hear your opinion on the changes I suggested to your updates.
Upon completion of these changes, and when the new
updater_1
is feature-complete and ready, I'll happily merge this to master, and mention you as a contributor on the README page, if you'd like!