Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods to Instant, matching Rust 1.39 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fusetim
Copy link

@fusetim fusetim commented Jul 11, 2021

Added some missing methods, introduced by Rust 1.39:

  • Instant::checked_duration_since

    Returns the amount of time elapsed from another instant to this one, or None if that instant is later than this one.

  • Instant::saturating_duration_since

    Returns the amount of time elapsed from another instant to this one, or zero duration if that instant is later than this one.

  • Instant::checked_add

    Returns Some(t) where t is the time self + duration if t can be represented as Instant (which means it’s inside the bounds of the underlying data structure), None otherwise.

    Since it is a floating number inside, this is always true.

  • Instant::check_sub

    Returns Some(t) where t is the time self - duration if t can be represented as Instant (which means it’s inside the bounds of the underlying data structure), None otherwise.

    Since it is a floating number inside this is always true.

@fusetim fusetim changed the title Adding missing methods to Instant, matching Rust 1.39 Add missing methods to Instant, matching Rust 1.39 Jul 11, 2021
}

pub fn checked_sub(&self, duration: Duration) -> Option<Instant> {
Some(*self - duration)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow creating a negative Instance, right?

Instant::now() - (Instant::now() + Duration::from_secs(1))

Copy link
Author

@fusetim fusetim Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, I don't know for sure if it should be avoided or not.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much think this should be avoided (across the whole crate). I do think we should mimic the behavior of the standard library here.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6e4ac52feea310c855e5a4d420e2d8ea

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This highly depends of the underlying implementation and could be different on an other platform. Nevertheless we could restrict the use of negative Instant.

I can't easily edit the PR for now, but I'll be back on August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants