-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing methods to Instant, matching Rust 1.39 #17
base: master
Are you sure you want to change the base?
Conversation
3aee2c2
to
39e1c28
Compare
} | ||
|
||
pub fn checked_sub(&self, duration: Duration) -> Option<Instant> { | ||
Some(*self - duration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow creating a negative Instance
, right?
Instant::now() - (Instant::now() + Duration::from_secs(1))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, I don't know for sure if it should be avoided or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much think this should be avoided (across the whole crate). I do think we should mimic the behavior of the standard library here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This highly depends of the underlying implementation and could be different on an other platform. Nevertheless we could restrict the use of negative Instant.
I can't easily edit the PR for now, but I'll be back on August.
Added some missing methods, introduced by Rust 1.39:
Instant::checked_duration_since
Instant::saturating_duration_since
Instant::checked_add
Since it is a floating number inside, this is always true.
Instant::check_sub
Since it is a floating number inside this is always true.