Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application/vnd.api+json content types #362

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

kfitzgerald
Copy link
Contributor

Greetings!

It's been a while, but I ran into an API that returns something called JSON-API: https://jsonapi.org/

Apparently it's too good to use regular old content-type: applcation/json, and had to invent their own mime type. Needless to say, it's still JSON with a specialized format. Woohoo!

All sarcasm aside, this PR treats their application/vnd.api+json content mime type as json.

Unit tests supporting the case added as well. Let me know how this looks and if there's anything else you need from me!

Thanks again,
-Kevin

@tomas
Copy link
Owner

tomas commented Jul 7, 2021

Looks great! Thanks Kevin

@tomas tomas merged commit cfc51be into tomas:master Jul 7, 2021
@kfitzgerald
Copy link
Contributor Author

Thanks again @tomas! Really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants