Emit 'done' event on writable streams Needle's response is being piped to #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us use a consistent API regardless listening to events on the response stream itself or to destination/writable streams.
This is one of the examples in the readme:
However if instead of processing the chunks manually you wanted to pipe to another stream, then you'd be attaching the
on('done')
listener to the target stream:This PR ensures that both Needle's response and its target streams, when piped, all emit the 'done' event, providing a more consistent way of piping streams.
On a related note, please take a look at #372 for more info regarding error handling on streams. The gist of it is that you should use
stream.pipeline
instead ofpipe
, when possible.