Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order by timestamp #35

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Order by timestamp #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24d2c3
Always order events by timestamp
Nov 1, 2017
7d5be18
Add required class constraint to metadata type
Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RdbmsEventStore.EntityFramework.Tests/Infrastructure/EventStoreFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class EventStoreFixture<TId, TStreamId, TEvent, TEventMetadata, TPersiste
where TStreamId : IEquatable<TStreamId>
where TEvent : class, TEventMetadata, IMutableEvent<TStreamId>, new()
where TPersistedEvent : class, TEventMetadata, IPersistedEvent<TStreamId>, new()
where TEventMetadata : IEventMetadata<TStreamId>
where TEventMetadata : class, IEventMetadata<TStreamId>
{
public EventStoreFixture()
{
Expand Down
2 changes: 1 addition & 1 deletion src/RdbmsEventStore.EntityFramework.Tests/Infrastructure/EventStoreTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace RdbmsEventStore.EntityFramework.Tests.Infrastructure
public class EventStoreTestBase<TId, TStreamId, TEvent, TEventMetadata, TPersistedEvent> : IClassFixture<EventStoreFixture<TId, TStreamId, TEvent, TEventMetadata, TPersistedEvent>>, IDisposable
where TId : IEquatable<TId>
where TStreamId : IEquatable<TStreamId>
where TEventMetadata : IEventMetadata<TStreamId>
where TEventMetadata : class, IEventMetadata<TStreamId>
where TEvent : class, TEventMetadata, IMutableEvent<TStreamId>, new()
where TPersistedEvent : class, TEventMetadata, IPersistedEvent<TStreamId>, new()
{
Expand Down
5 changes: 4 additions & 1 deletion src/RdbmsEventStore.EntityFramework/EntityFrameworkEventStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class EntityFrameworkEventStore<TId, TStreamId, TContext, TEvent, TEventM
where TContext : DbContext, IEventDbContext<TPersistedEvent>
where TEvent : class, TEventMetadata, IMutableEvent<TStreamId>, new()
where TPersistedEvent : class, IPersistedEvent<TStreamId>, TEventMetadata, new()
where TEventMetadata : IEventMetadata<TStreamId>
where TEventMetadata : class, IEventMetadata<TStreamId>
{
private readonly TContext context;
private readonly IEventFactory<TStreamId, TEvent> _eventFactory;
Expand All @@ -35,6 +35,7 @@ public async Task<IEnumerable<TEvent>> Events(Func<IQueryable<TEventMetadata>, I
var storedEvents = await context.Events
.AsNoTracking()
.Apply(query)
.OrderBy(e => e.Timestamp)
.ToListAsync();

var events = storedEvents
Expand All @@ -52,7 +53,9 @@ public async Task<IEnumerable<TEvent>> Events(TStreamId streamId, Func<IQueryabl
.Where(e => e.StreamId.Equals(streamId))
.AsNoTracking()
.Apply(query)
.OrderBy(e => e.Timestamp)
.ToListAsync();

var events = storedEvents
.Cast<TPersistedEvent>()
.Select(_serializer.Deserialize);
Expand Down