Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose the version number #47

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Don't expose the version number #47

merged 1 commit into from
Dec 5, 2017

Commits on Dec 5, 2017

  1. Don't expose the version number 

    Exposing the version number is problematic, since if we want to change
history by deleting or adding events in the past, we have to re-version
every single event that comes later in the stream.

Instead, we now use timestamps for versioning.

However, neither EF nor EF Core guarantees the ordering of entities that
are inserted in the same batch, which means we need a way to version
events that are inserted togehter to ensure that they are retreived in
the same order they were created. Therefore, we keep the Version property
on the persisted event types, but use it only internally inside the EF
providers.

The version number is also now grouped per timestamp, so that for each new
timestamp the version number restarts.
    Tomas Lycken committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    38ca751 View commit details
    Browse the repository at this point in the history