Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8] file names with prefix ./ are not detected #58

Closed
uhafner opened this issue Feb 7, 2019 · 2 comments
Closed

[flake8] file names with prefix ./ are not detected #58

uhafner opened this issue Feb 7, 2019 · 2 comments

Comments

@uhafner
Copy link
Contributor

uhafner commented Feb 7, 2019

See jenkinsci/analysis-model@881b1cf

@pabepadu
Copy link

pabepadu commented Feb 8, 2019

I had a look in the parser:
violations-lib/src/main/java/se/bjurr/violations/lib/parsers/Flake8Parser.java

I think it's not due to the ./ but the column part, the pattern matching accept only 1 decimal:
"([^:]*):(\\d+)?:?(\\d)?:? \\[?(\\D+)(\\d*)\\]? (.*)"
and it should be with a +, like this:
"([^:]*):(\\d+)?:?(\\d+)?:? \\[?(\\D+)(\\d*)\\]? (.*)"

tomasbjerre added a commit that referenced this issue Feb 10, 2019
@tomasbjerre
Copy link
Owner

You are right @pabepadu !

Released a fix as 1.81 now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants