[BUGFIX] Change Middleware registration order for the Crawler to avo…

…id problems wiht ext:StaticFileCache

Resolves: #642 and lochmueller/staticfilecache#260

CHANGELOG.md

@@ -21,6 +21,7 @@
 * Updated Rector, PHPStan, ECS for better static code analysis
 * BackendModule is splittet into smaller classes to improve readability and maintainability
 * Crawler Class added, this can be used to check whether the crawler is enabled or disabled
+* aoe/crawler/initialization (middleware) is moved to before typo3/cms-core/normalizedParams to have crawler being "last" in middleware chain
 
 ### Fixed
 

Classes/Backend/RequestForm/LogRequestForm.php

@@ -355,7 +355,7 @@ private function drawLog_addRows(array $logEntriesOfPage, string $titleString):
 
                 $trClass = '';
                 $warningIcon = '';
-                if ($rowData['exec_time'] !== 0 && $resultData === false) {
+                if (str_contains($resStatus, 'Error:')) {
                     $trClass = 'class="bg-danger"';
                     $warningIcon = $this->getIconFactory()->getIcon('actions-ban', Icon::SIZE_SMALL);
                 }

Configuration/RequestMiddlewares.php

@@ -18,11 +18,8 @@
         ],
         'aoe/crawler/initialization' => [
             'target' => CrawlerInitialization::class,
-            'after' => [
-                'typo3/cms-frontend/tsfe',
-            ],
             'before' => [
-                'typo3/cms-frontend/prepare-tsfe-rendering',
+                'typo3/cms-core/normalizedParams',
             ],
         ],
     ],

phpstan-baseline.neon

@@ -46,12 +46,12 @@ parameters:
 			path: Classes/Backend/Helper/ResultHandler.php
 
 		-
-			message: "#^Class cognitive complexity for \"LogRequestForm\" is 68, keep it under 50$#"
+			message: "#^Class cognitive complexity for \"LogRequestForm\" is 67, keep it under 50$#"
 			count: 1
 			path: Classes/Backend/RequestForm/LogRequestForm.php
 
 		-
-			message: "#^Class cognitive complexity for \"LogRequestForm\" is 68, keep it under 60$#"
+			message: "#^Class cognitive complexity for \"LogRequestForm\" is 67, keep it under 60$#"
 			count: 1
 			path: Classes/Backend/RequestForm/LogRequestForm.php
 
@@ -86,7 +86,7 @@ parameters:
 			path: Classes/Backend/RequestForm/LogRequestForm.php
 
 		-
-			message: "#^Cognitive complexity for \"AOE\\\\Crawler\\\\Backend\\\\RequestForm\\\\LogRequestForm\\:\\:drawLog_addRows\\(\\)\" is 41, keep it under 8$#"
+			message: "#^Cognitive complexity for \"AOE\\\\Crawler\\\\Backend\\\\RequestForm\\\\LogRequestForm\\:\\:drawLog_addRows\\(\\)\" is 40, keep it under 8$#"
 			count: 1
 			path: Classes/Backend/RequestForm/LogRequestForm.php
 
@@ -115,11 +115,6 @@ parameters:
 			count: 1
 			path: Classes/Backend/RequestForm/LogRequestForm.php
 
-		-
-			message: "#^Offset 'exec_time' does not exist on array\\('result_log' \\=\\> string, 'result_status' \\=\\> string, 'url' \\=\\> string, 'feUserGroupList' \\=\\> mixed, 'procInstructions' \\=\\> string, 'set_id' \\=\\> string, \\?'tsfe_id' \\=\\> mixed, \\?'tsfe_gr_list' \\=\\> mixed, \\.\\.\\.\\)\\|array\\('scheduled' \\=\\> string, 'exec_time' \\=\\> string, 'result_status' \\=\\> string, 'url' \\=\\> string, 'feUserGroupList' \\=\\> mixed, 'procInstructions' \\=\\> string, 'set_id' \\=\\> string, \\?'tsfe_id' \\=\\> mixed, \\.\\.\\.\\)\\.$#"
-			count: 1
-			path: Classes/Backend/RequestForm/LogRequestForm.php
-
 		-
 			message: "#^Parameter \\#2 \\$pieces of function implode expects array, array\\<int, string\\>\\|false given\\.$#"
 			count: 1