[FEATURE] Inform when pages does not exists when calling crawler:buil…

…dQueue from cli (#1098)
tomasnorre · Oct 6, 2024 · 8ad77e0 · 8ad77e0
1 parent 2ce75a8
commit 8ad77e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Added
 * Possibility to flush all processes from the backend module in process view
+* Information when page does not exists when crawler:buildQueue command is called from cli
 
 ### Changed
 

diff --git a/Classes/Command/BuildQueueCommand.php b/Classes/Command/BuildQueueCommand.php
@@ -33,6 +33,7 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
+use TYPO3\CMS\Core\Domain\Repository\PageRepository;
 use TYPO3\CMS\Core\EventDispatcher\EventDispatcher;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
@@ -122,13 +123,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $crawlerController = GeneralUtility::makeInstance(CrawlerController::class);
         /** @var QueueRepository $queueRepository */
         $queueRepository = GeneralUtility::makeInstance(QueueRepository::class);
+        $pageRepository = GeneralUtility::makeInstance(PageRepository::class);
 
         if ($mode === 'exec') {
             $crawlerController->registerQueueEntriesInternallyOnly = true;
         }
 
         $pageId = MathUtility::forceIntegerInRange((int) $input->getArgument('page'), 0);
-        if ($pageId === 0) {
+        if ($pageId === 0 || empty($pageRepository->getPage($pageId))) {
             $message = "Page {$pageId} is not a valid page, please check you root page id and try again.";
             MessageUtility::addErrorMessage($message);
             $output->writeln("<info>{$message}</info>");
@@ -188,9 +190,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 $progressBar->clear();
                 if (is_array($requestResult)) {
                     $resLog = array_key_exists('log', $requestResult)
-                    && is_array($requestResult['log']) ? PHP_EOL . chr(9) . chr(9) .
+                    && is_array($requestResult['log']) ? chr(9) . chr(9) .
                         implode(PHP_EOL . chr(9) . chr(9), $requestResult['log']) : '';
-                    $output->writeln('<info>OK: ' . $resLog . '</info>' . PHP_EOL);
+                    $output->writeln('<info>OK: ' . $resLog . '</info>');
                 } else {
                     $output->writeln(
                         '<error>Error checking Crawler Result:  ' . substr(
@@ -236,7 +238,7 @@ private function outputUrls(array $queueRows, OutputInterface $output): void
             if (empty($row->message)) {
                 $output->writeln('<info>' . $row->urls . '</info>');
             } else {
-                $output->writeln('<warning>' . $row->pageTitle . ': ' . $row->message . '</warning>');
+                $output->writeln('<comment>' . $row->pageTitle . ': ' . $row->message . '</comment>');
             }
         }
     }