Fix _ADDTABLE behavior #1009
Merged
Fix _ADDTABLE behavior #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had issues using the _ADDTABLE parameter after upgrading an old installation from v6.7.3 to v10.0.3: We use configurations like `[_TABLE:tx_news_domain_model_news;_ADDTABLE:, sys_category_record_mm;_PID:1;_WHERE: hidden = 0 AND tx_news_domain_model_news.uid = sys_category_record_mm.uid_foreign AND uid_local = 2]` to restrict the category for news entries found by the crawler. With your code this results in queries like `SELECT uid FROM , , WHERE (pid IN (?)) AND (hidden = 0 AND tx_news_domain_model_news.uid = sys_category_record_mm.uid_foreign AND uid_local = 1)`. Of course, this will result in an error. With my changes it is possible to add several additional tables separated by commas. Even our old configuration would work, although the comma at the beginning is no longer needed. This is only tested with v10.0.3 on TYPO3 v9.5.31 as the upgrade is still in progress...
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@tomasnorre Could you please add this fix also to the v11.x branch? |
|
@Hawkeye1909 Yes, I can do so to. It would ease the process if you create a PR for that branch too ;) |
Hawkeye1909
added a commit
to Hawkeye1909/crawler
that referenced
this pull request
Jul 30, 2024
tomasnorre
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had issues using the _ADDTABLE parameter after upgrading an old installation from v6.7.3 to v10.0.3:
We use configurations like
[_TABLE:tx_news_domain_model_news;_ADDTABLE:, sys_category_record_mm;_PID:1;_WHERE: hidden = 0 AND tx_news_domain_model_news.uid = sys_category_record_mm.uid_foreign AND uid_local = 2]to restrict the category for news entries found by the crawler. With your code this results in queries likeSELECT uid FROM , , WHERE (pid IN (?)) AND (hidden = 0 AND tx_news_domain_model_news.uid = sys_category_record_mm.uid_foreign AND uid_local = 1). Of course, this will result in an error.With my changes it is possible to add several additional tables separated by commas. Even our old configuration would work, although the comma at the beginning is no longer needed.
This is only tested with v10.0.3 on TYPO3 v9.5.31 as the upgrade is still in progress...
Description
I have