Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent undefined array key uid and username in FrontendUserAuthentication #1014

Merged
merged 1 commit into from
May 23, 2023

Conversation

Patta
Copy link
Contributor

@Patta Patta commented May 22, 2023

Description

Prevents undefined array key uid and username warnings in FrontendUserAuthentication middleware.
Resolves #1012 which blows up the sys_log on every requested login protected page in queue.
Perhaps not the cleanest solution.

I have

  • Checked that CGL are followed
  • Checked that the Tests are still working
  • Added description to CHANGELOG.md (github-handle is optional)
  • Added tests for the new code

@tomasnorre tomasnorre merged commit 604cc67 into tomasnorre:v11.x May 23, 2023
@derBoogie
Copy link

I have applied the patch (604cc67), but still get the following warnings:

  • PHP Warning: Undefined array key "set_id" in /html/typo3/typo3conf/ext/crawler/Classes/Middleware/FrontendUserAuthenticator.php line 119
  • PHP Warning: Undefined array key "qid" in /html/typo3/typo3conf/ext/crawler/Classes/Middleware/FrontendUserAuthenticator.php line 119

TYPO3 11.5.29, crawler 11.0.7

@tomasnorre
Copy link
Owner

Someone (TM) would need to look into this again then.

@Patta
Copy link
Contributor Author

Patta commented Aug 8, 2023

@derBoogie I also saw these warnings after warming up the cache after deployment, but not on planned crawling tasks. Could you open a new issue?

@Patta
Copy link
Contributor Author

Patta commented May 29, 2024

@tomasnorre this "fix" seems missing in main (v12) branch.

$frontendUser->user[$frontendUser->usergroup_column] = '0,-2,' . $grList;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants