Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix CSS class for select item in backend module #1080

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

derhansen
Copy link
Contributor

No description provided.

@tomasnorre
Copy link
Owner

tomasnorre commented Jun 21, 2024

First, thank you for your contribution, that one slipped my attention.

I don't get why all the tests are red, your change should have nothing to do with that.

Can I get you to add a comment to the CHANGELOG.md just for triggering a new build, don't know if anything timed out before I approved the workflow.

@derhansen
Copy link
Contributor Author

Maybe problems with testing framework. There was just released a news version recently - see https://github.com/TYPO3/testing-framework/releases/tag/8.1.1

@tomasnorre tomasnorre merged commit 68e7258 into tomasnorre:main Jun 22, 2024
8 of 34 checks passed
@tomasnorre
Copy link
Owner

It works locally with the 8.1.1 tag with both PHP 8.1 and 8.3, so I don't think that's the problem. I have merged your change as it cannot break anything besides layout.

@tomasnorre
Copy link
Owner

Strange it worked in the merge to main. https://github.com/tomasnorre/crawler/actions/runs/9623324396/job/26545650109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants