Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #1009 #1089

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Backport of #1009 #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad4df5
Backport of #1009
Hawkeye1909 Jul 30, 2024
4f2cefd
Update CHANGELOG.md
Hawkeye1909 Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Changelog TYPO3 Crawler

## Crawler 11.0.11-dev

### Added

### Changed

### Fixed
* Fixed query building when using _ADDTABLE parameter [@hawkeye1909](https://github.com/hawkeye1909)

### Deprecated

#### Classes

#### Functions & Properties

### Removed

#### Classes

#### Functions & Properties

## Crawler 11.0.10

Crawler 11.0.10 was released on July 4th, 2024
Expand Down
5 changes: 4 additions & 1 deletion Classes/Service/ConfigurationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php

Check failure on line 1 in Classes/Service/ConfigurationService.php

View workflow job for this annotation

GitHub Actions / PHPstan 

Ignored error pattern #^Class cognitive complexity is 98, keep it under 60$# in path /home/runner/work/crawler/crawler/Classes/Service/ConfigurationService.php was not matched in reported errors.

declare(strict_types=1);

Expand Down Expand Up @@ -38,7 +38,7 @@
/**
* @internal since v9.2.5
*/
class ConfigurationService

Check failure on line 41 in Classes/Service/ConfigurationService.php

View workflow job for this annotation

GitHub Actions / PHPstan 

Class cognitive complexity is 106, keep it under 60
{
/**
* @var BackendUserAuthentication|null
Expand Down Expand Up @@ -280,7 +280,10 @@

if (! empty($addTable)) {
// TODO: Check if this works as intended!
$queryBuilder->add('from', $addTable);
$addTables = GeneralUtility::trimExplode(',', $addTable, true);
foreach ($addTables as $table) {
$queryBuilder->from($table);
}
}
$transOrigPointerField = $GLOBALS['TCA'][$subpartParams['_TABLE']]['ctrl']['transOrigPointerField'];

Expand Down
Loading