[BUGFIX] Catch E_WARNING when unserialize() fails #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2025
|
Thanks for your PR. I'll review one of the next days. |
tomasnorre
reviewed
Jan 15, 2025
Since PHP 8.3, unserialize() throws an E_WARNING instead of E_NOTICE. This leads to an error when viewing crawler information for pages and when crawling sites: > PHP Warning: unserialize(): Error at offset 0 of 122 bytes > in typo3conf/ext/crawler/Classes/Converter/JsonCompatibilityConverter.php line 39 Resolves: tomasnorre#1087
cweiske
force-pushed
the
unserialize-warning
branch
from
670dd21 to
c993840
Compare
|
Version 11.0.11 has the fix. |
Thanks, think it simply forgot to update the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.3, unserialize() throws an E_WARNING instead of E_NOTICE. This leads to an error when viewing crawler information for pages and when crawling sites:
This patch solves the problem in the most non-invasive way by simply catching the unserialize warning.
Resolves: #1087
Description
I have