Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not recognize .svelte.erb #113

Closed
sedubois opened this issue May 2, 2020 · 4 comments · Fixed by #100
Closed

Does not recognize .svelte.erb #113

sedubois opened this issue May 2, 2020 · 4 comments · Fixed by #100

Comments

@sedubois
Copy link

sedubois commented May 2, 2020

Thanks for this very helpful IntelliJ IDEA plugin! It's been a pleasure to learn using Svelte using the IDEA thanks to this.

It handles *.svelte files very well, however it does not recognize .svelte.erb files as Svelte files (although this is supported by Webpacker). Could this somehow be supported?

@tomblachut
Copy link
Owner

tomblachut commented May 2, 2020

Hi, thanks for the kind words.

Can you give me an example of .svelte.erb file?

@tomblachut tomblachut added the waiting for reply Further information is requested label May 2, 2020
@sedubois
Copy link
Author

sedubois commented May 3, 2020

@tomblachut the code below renders "hello from http://localhost:3000/" when run locally:

// Hello.svelte.erb
<script>
  let host = "<%= ENV['HOST'] %>"
</script>

<p>hello from {host}</p>

@tomblachut
Copy link
Owner

I've opened this snipped in next version (#100) and it looks like this:

image

I guess this is good enough, right?

@tomblachut tomblachut removed the waiting for reply Further information is requested label May 3, 2020
@tomblachut tomblachut linked a pull request May 3, 2020 that will close this issue
6 tasks
@sedubois
Copy link
Author

sedubois commented May 3, 2020

Yes the ERB syntax only seems partly recognized but at least the Svelte syntax seems good 👍

So I'll be watching for the next release including this change 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants