Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add optional padding parameter to fitBounds method #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreiho
Copy link

fitBounds methods now supports an optional padding parameter.

https://developers.google.com/maps/documentation/javascript/reference/map#Map.fitBounds

@scoobster17
Copy link

Any progress on fixing the checks?

Seems the issue thrown is TypeError: Invalid attempt to destructure non-iterable instance. A quick google didn't provide much help, and I can't see anything wrong at a glance in the 2 places that the arguments are destructured (here).

Keen to get this type change merged 😄

@andreiho
Copy link
Author

andreiho commented Feb 6, 2019

@scoobster17 That error isn't related to this PR, it's reproducible on master. Also this repo seems to have died, there hasn't been a release in over a year. I've been using my fork with the new types ever since with no issues. You're welcome to use it as well.

@JustFly1984
Copy link

@andreiho @scoobster17 please check npm @react-google-maps/api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants