Add delay prop to HolyLoader component #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tomcru#2 Add delay prop to HolyLoader component to delay the start of the progress bar. * Add `delay` prop to `HolyLoaderProps` interface in `src/index.tsx` with a default value of 0. * Modify `HolyLoader` component in `src/index.tsx` to use the `delay` prop to delay the start of the progress bar. * Update `useEffect` hook in `src/index.tsx` to handle the delay logic before starting the progress bar. * Add documentation for the new `delay` prop in the API section of `README.md`. * Add tests in `src/__tests__/HolyLoader.test.ts` to verify the functionality of the `delay` prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Add delay prop to HolyLoader component to delay the start of the progress bar.
delayprop toHolyLoaderPropsinterface insrc/index.tsxwith a default value of 0.HolyLoadercomponent insrc/index.tsxto use thedelayprop to delay the start of the progress bar.useEffecthook insrc/index.tsxto handle the delay logic before starting the progress bar.delayprop in the API section ofREADME.md.src/__tests__/HolyLoader.test.tsto verify the functionality of thedelayprop.