Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the problem with class AsyncResult when using self._is_ready.wait() in wait function #463

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

achrafka
Copy link

@achrafka achrafka commented Nov 4, 2021

in this pull request i did this:

1- instead of using Threading and the inbuilt method is_set() which it caused problems i used False and only self._is_ready

@achrafka achrafka changed the title fixing the problem with class AsyncResult when using Threading instea… fixing the problem with class AsyncResult when using self._is_ready.wait() Nov 6, 2021
@achrafka achrafka changed the title fixing the problem with class AsyncResult when using self._is_ready.wait() fixing the problem with class AsyncResult when using self._is_ready.wait() in wait function Nov 6, 2021
@comrumino comrumino merged commit 312644c into tomerfiliba-org:master Nov 9, 2021
@wumb0
Copy link
Contributor

wumb0 commented Nov 12, 2021

This undoes my fix from #455
Edit: I see what you did, you removed the Event stuff in the first commit and then added it back in your second.
Confusing, but it should be fine.

@achrafka
Copy link
Author

Yeah in the second place i did more investigation and i found out that the problem is in the function wait()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants