Allow filtering by host on list_services #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the list_services, I figured that I needed to filter the list of services received depending on the host
(i.e. only receiving the services running on xxx.xxx.0.22 for example)
I had two options :
Filtering the list post request by using discover()
-> Pro: no additional processing on the registry
-> Con: add a lot of calls to discover() so more demanding for the network, as well as slower execution time.
Filtering the list during the request by sending an additional parameter:
-> Pro: no extra charge on the network, and faster execution time.
-> Con: some processing is needed on the registry
I went with the second option since speed of execution is more critical.