logrotate logfile on EL6 - fixes #14 & #15 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the successor of #19 as we can't silence consul on STDOUT and hashicorp recommends to deal with that through external tools: hashicorp/consul#261 |
consul logs by default to STDOUT which is captured by systemd on newer systems. On a sysv-init based system - like EL6 - we redirect that to our own logfile. Which then just grows continously. As enabling logging to syslog in consul does not silence output to stdout, we would now log twice. So on these systems we should logrotate that logfile to avoid growing the file endless.
duritong
force-pushed
the
logrotate_on_el6
branch
from
18b6c19 to
79d1637
Compare
|
I don't run Consul on any EL6 machines, so I am not necessarily authoritative, but based on the content of hashicorp/consul#261 this PR seems reasonable. 😄
|
|
So finally I was able to verify that this works properly. And although I'm not a fan of merging my own PRs it seems that I am the only one that needs this, so I'm going to merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consul logs by default to STDOUT which is captured by systemd on
newer systems. On a sysv-init based system - like EL6 - we redirect
that to our own logfile. Which then just grows continously. As
enabling logging to syslog in consul does not silence output
to stdout, we would now log twice. So on these systems we should
logrotate that logfile to avoid growing the file endless.