Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Output wrong on actual collection date #5

Closed
tomislacker opened this issue Dec 27, 2016 · 0 comments · Fixed by #6
Closed

Output wrong on actual collection date #5

tomislacker opened this issue Dec 27, 2016 · 0 comments · Fixed by #6
Assignees
Labels

Comments

@tomislacker
Copy link
Owner

tomislacker commented Dec 27, 2016

Bug Report

When it's currently garbage day, the dead-reckoning search for <strong> elements breaks down and has mismatched response values.

Execution Output

2016-12-27 14:31:47 - mke-refuse - DEBUG - Parsing arguments
2016-12-27 14:31:47 - mke-refuse - DEBUG - Composing query address
2016-12-27 14:31:47 - mke-refuse - INFO - Executing query...
2016-12-27 14:31:47 - requests.packages.urllib3.connectionpool - DEBUG - Starting new HTTP connection (1): mpw.milwaukee.gov
2016-12-27 14:31:47 - requests.packages.urllib3.connectionpool - DEBUG - http://mpw.milwaukee.gov:80 "POST /services/garbage_day HTTP/1.1" 200 None
2016-12-27 14:31:47 - RefusePickup - INFO - Reading through 13893 bytes for 6 properties...
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'success_msg': //*[@id="nConf"]/h1
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'next_pickup_recycle_before': //*[@id="nConf"]/strong[5]
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'route_recyle': //*[@id="nConf"]/strong[3]
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'next_pickup_recycle_after': //*[@id="nConf"]/strong[4]
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'next_pickup_garbage': //*[@id="nConf"]/strong[2]
2016-12-27 14:31:47 - RefusePickup - DEBUG - Searching for 'route_garbage': //*[@id="nConf"]/strong[1]
2016-12-27 14:31:47 - mke-refuse - INFO - Query returned
{
    "success_msg": "1234 N 15TH ST - Address located!",
    "next_pickup_recycle_after": "NR1-2-3",
    "next_pickup_garbage": "Today",
    "route_recyle": "TUESDAY DECEMBER 27, 2016",
    "route_garbage": "NA1-2A",
    "next_pickup_recycle_before": "TUESDAY JANUARY 3, 2017"
}

HTML Output

<h1>1234 N 15TH ST - Address located!</h1>
<h2>Next Scheduled Garbage Pickup:</h2>
The winter garbage pickup route for this location is <strong>NA1-2A</strong>.<br/><br/><strong>Today</strong> is a garbage collection date for this location!<br/><br/>The next garbage collection pickup for this location is: <strong>TUESDAY DECEMBER 27, 2016</strong><br/  ><br/>Click <a href='http://mpw.milwaukee.gov/san_collection_files/SUMMER/Garbage Green (ASL).pdf'>here</a> to see your complete garbage collection schedule.<br/><br/>
<h2>Next Scheduled Recycling Pickup:</h2>
Because of weather events and Holidays, the recycling collection dates are not guaranteed in the winter.<br/><br/>The winter recycling pickup route for this location is <strong>NR1-2-3</strong>.<br/><br/>The next estimated pickup time is between <strong>TUESDAY JANUARY 3, 2017</strong> and <strong>WEDNESDAY JANUARY 4, 2017</strong>.<br/><br/>

Expected Output

{
    "success_msg": "1234 N 15TH ST - Address located!",
    "next_pickup_recycle_after": "TUESDAY JANUARY 3, 2017",
    "next_pickup_garbage": "TUESDAY DECEMBER 27, 2016",
    "route_recyle": "NR1-2-3",
    "route_garbage": "NA1-2A",
    "next_pickup_recycle_before": "WEDNESDAY JANUARY 4, 2017"
}

Expected Output (Diff)

3,5c3,5
<     "next_pickup_recycle_after": "NR1-2-3",
<     "next_pickup_garbage": "Today",
<     "route_recyle": "TUESDAY DECEMBER 27, 2016",
---
>     "next_pickup_recycle_after": "TUESDAY JANUARY 3, 2017",
>     "next_pickup_garbage": "TUESDAY DECEMBER 27, 2016",
>     "route_recyle": "NR1-2-3",
7c7
<     "next_pickup_recycle_before": "TUESDAY JANUARY 3, 2017"
---
>     "next_pickup_recycle_before": "WEDNESDAY JANUARY 4, 2017"
@tomislacker tomislacker self-assigned this Dec 27, 2016
tomislacker added a commit that referenced this issue Dec 29, 2016
This is in-support or RCA on #5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant