Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackage lts 7.19 #268

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Conversation

WillSewell
Copy link
Contributor

I wanted to make this compatible with aeson-1.1.*. In doing so I did a stackage lts upgrade because it was quite out of date. I also updated the relevant upper bounds.

I can remove the last commit if you would prefer (and you are happy with the tests passing).

@@ -40,7 +40,7 @@ import qualified Data.Functor.Identity as I
-- 'ProductProfunctor') in @s@ and @t@. It is unclear at this point
-- whether we want the same @Traversal@ laws to hold or not. Our use
-- cases may be much more general.
data PackMap a b s t = PackMap (Applicative f =>
data PackMap a b s t = PackMap (forall f. Applicative f =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure which change in the compiler necessitated this change. However it appears to be backwards compatible, so I don't see a problem with it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's something that had to change in Opaleye a while ago but I didn't fix the sqlite version at the same time.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillSewell Are you actually using opaleye-sqlite? I'm not sure how widely used it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I'm not, but I thought I'd update the deps for it since I was updating the stack.yaml resolver version anyway.

@tomjaguarpaw
Copy link
Owner

Thanks Will, this is great.

@tomjaguarpaw tomjaguarpaw merged commit 3b46d02 into tomjaguarpaw:master Feb 10, 2017
@WillSewell
Copy link
Contributor Author

No problem. Thanks for merging :) It would be good if this could be released soon, otherwise opaleye won't make it into Stackage nightly builds after LTS 8.0 is out: commercialhaskell/stackage#2177 (comment).

@tomjaguarpaw
Copy link
Owner

I uploaded this last night. Is that sufficient?

https://hackage.haskell.org/package/opaleye-0.5.3.0

@WillSewell
Copy link
Contributor Author

Ah yes. I was looking for a new version in the GitHub repo, but it looks like you haven't pushed the commit where you bumped the version yet.

@tomjaguarpaw
Copy link
Owner

Good point. I'm continually stymied by git push --tags not actually pushing the commits that the tags refer to!

Anyway, the new version is now on github master.

@WillSewell WillSewell deleted the stackage-lts-7.19 branch March 1, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants