Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyfilling 16.4 lifecycles and rewriting how Pane gets size updates #269

Merged
merged 5 commits into from
Jun 18, 2018

Conversation

wuweiweiwu
Copy link
Collaborator

@wuweiweiwu wuweiweiwu commented Jun 16, 2018

closes: #261

moving from cWRP -> gDFSP with polyfill

Pane will get size updates through props.

added .prettierrc file for prettier configuration

  • tests
  • smoke tests (demo site)
  • lint
  • update lock file

@coveralls
Copy link

coveralls commented Jun 16, 2018

Coverage Status

Coverage increased (+0.04%) to 91.416% when pulling abe8723 on wuweiweiwu:better-pane-size into 72191eb on tomkp:master.

@wuweiweiwu wuweiweiwu changed the title WIP: polyfilling 16.4 lifecycles and rewriting how Pane gets size updates polyfilling 16.4 lifecycles and rewriting how Pane gets size updates Jun 17, 2018
@tomkp tomkp merged commit 918a481 into tomkp:master Jun 18, 2018
@tomkp
Copy link
Owner

tomkp commented Jun 18, 2018

Great work!! Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usages of unsafe lifecycle methods
3 participants