Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react v17 #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support react v17 #681

wants to merge 1 commit into from

Conversation

moritzmhmk
Copy link

Added 17.0.0 to the possible versions of react in the peer dependencies. Tested in a project with react v17 and works fine!

@maclockard maclockard mentioned this pull request Mar 22, 2021
@raptoria
Copy link

Can this be merged?

@yuchonghua
Copy link

Look forward to supporting React17 soon

@JeremyGrieshop
Copy link

NPMv7 prevents this package from being installed in a lot of projects because of unmet peerDependencies. The only other option is to use --legacy-peer-deps, which often causes even more problems than its worth.

@somguyth
Copy link

When is this happening?

@JeremyGrieshop
Copy link

JeremyGrieshop commented Jul 15, 2021

May as well add React 18, too 😂

@repartay
Copy link

+1 for merge. Would very much like to continue using this library in new projects.

@george-thomas-hill
Copy link

Bump!

@tylermichael
Copy link

@tomkp Can this be merged? Thanks!

@ran-lc
Copy link

ran-lc commented Dec 9, 2021

+1 for merge

@gsanta
Copy link

gsanta commented Dec 23, 2021

merge!

@JeremyGrieshop
Copy link

FWIW, this is a pretty small component and can be easily dropped into a folder inside your project, with a favorable MIT license. I did this a couple of months ago, when it appeared that there wasn't much movement on commits/merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants