Add shorthand for escape character #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a shorthand for the escape character `\e` (0x1B). This is useful especially when talking about things like terminal escape sequences, which use this character regularly. Fixes toml-lang#715.
|
I'm aware that the inclusion of this shorthand is not agreed upon yet. But I thought I might as well just send a PR right away so it doesn't just sit around as an issue nobody cares about. Feel free to just close this if the decision has been made against supporting it. But I think it would be a nice addition. |
|
If it does pass muster (and I personally support its inclusion), it probably won't come in before v1.0.0 is released. |
|
1.0 has been released, so an evaluation of this feature (and the related issue) might be relevant now? |
|
Thanks for filing a complete PR for this @chrisduerr! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shorthand for the escape character
\e(0x1B).This is useful especially when talking about things like terminal escape
sequences, which use this character regularly.
Fixes #715.