-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterating on toml_edits API #122
Comments
Proposal: DateTime variants are flattened into
We take a lesson from tomlkit and consolidate all table types.
|
for Table vs InlineTable we have |
Your proposal sounds good to me. One thing I'm not sure about is
I think we should make as predictable for users as possible with no magic involved. |
This creates newtypes for each date/time type that enforce their format and allow conversion to/from it by the user. This also flattens `DateTime` into `Value`. This is part of toml-rs#122
* fix(repr): Loosen trait bounds * fix(datetime): Remove chrono from API This creates newtypes for each date/time type that enforce their format and allow conversion to/from it by the user. This also flattens `DateTime` into `Value`. This is part of #122
In working on TOML 1.0 compliance, some things have come up (#120)
cfg(test)
tricks work for black box tests, I'm going to be later be usingtoml_edit
intoml_test
as the baseline for testing encoders and validating againsttoml-rs
Value::DateTime
is verbose and we don't do it for integer/fl;oat (feat: Publicly exposeDateTime
#120, style: Silence clippy #116)toml-rs
on top oftoml_edit
, where should it live? A separate crate, atoml_edit::simple
module?Table
andInlineTable
is already a challenging and adding dotted keys is going to make this more challengingWith additional inputs
get_mut
(as_table_like_ mut? #110) andIndexMut
The text was updated successfully, but these errors were encountered: