feat(datetime): impl Serialize/Deserialize for Date/Time #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jul 30, 2024
epage
reviewed
Jul 30, 2024
crates/toml/tests/testsuite/serde.rs
Outdated
Comment on lines
1374
to
1377
| let err = toml::from_str::<Document>("time = 2024-01-01T05:00:00").unwrap_err(); | ||
| assert_data_eq!( | ||
| err.message(), | ||
| str!["expected only time portion of datetime"] |
There was a problem hiding this comment.
All commits should be passing. When adding tests in a commit before doing feature work, make them show the current behavior.
See https://github.com/toml-rs/toml/blob/main/CONTRIBUTING.md#process
Add tests in a commit before their feature or fix, showing the current behavior. The diff for the feature/fix commit will then show how the behavior changed, making it clearer to reviewrs and the community and showing people that the test is verifying the expected state.
e.g. clap-rs/clap#5520
epage
reviewed
Jul 30, 2024
crates/toml_datetime/src/datetime.rs
Outdated
| time: None, | ||
| offset: None, | ||
| } => Ok(date), | ||
| _ => Err(de::Error::custom("expected only date portion of datetime")), |
There was a problem hiding this comment.
I feel like Error::invalid_type would be more appropriate for these
loqusion
force-pushed
the
main
branch
2 times, most recently
from
3abe5d4
to
299e668
Compare
|
Weird, unsure why thnis was closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763