Skip to content

Commit

Permalink
chore: Move history, extension managers to core directory
Browse files Browse the repository at this point in the history
  • Loading branch information
@tomlin7
tomlin7 committed Feb 6, 2024
1 parent 9afefdf commit 8b09fa8
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 0 additions & 2 deletions biscuit/core/components/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@
Contains all the components of editor (Editor, Games, Git, LSP, Extensions Manager, Views, Menus and Palette)
"""
from .editors import BaseEditor, Editor
from .extensions import ExtensionManager
from .floating import *
from .games import BaseGame, register_game
from .git import Git
from .history import HistoryManager
from .lsp import LanguageServerManager
from .views import *
2 changes: 2 additions & 0 deletions biscuit/core/config.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

from .api import *
from .components import *
from .extensions import ExtensionManager
from .history import HistoryManager
from .settings import *
from .utils import *

Expand Down
0 biscuit/core/components/extensions.py → biscuit/core/extensions.py
View file
File renamed without changes.
6 changes: 3 additions & 3 deletions biscuit/core/components/history.py → biscuit/core/history.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
import sqlite3
import typing

from biscuit.core.components.floating.palette.actionset import ActionSet
from biscuit.core.components.utils import FixedSizeStack
from .components.floating.palette.actionset import ActionSet
from .components.utils import FixedSizeStack

if typing.TYPE_CHECKING:
from biscuit.core import App
from . import App


class HistoryManager:
Expand Down

2 comments on commit 8b09fa8

@ltaoist
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, I was amused, the leader call such as a "chore". Nice chore is important to keep understand for community

@tomlin7
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltaoist its following the semantic commit message conventions

Format: <type>(<scope>): <subject>

is optional

Example

feat: add hat wobble
^--^  ^------------^
|     |
|     +-> Summary in present tense.
|
+-------> Type: chore, docs, feat, fix, refactor, style, or test.

More Examples:

feat: (new feature for the user, not a new feature for build script)
fix: (bug fix for the user, not a fix to a build script)
docs: (changes to the documentation)
style: (formatting, missing semi colons, etc; no production code change)
refactor: (refactoring production code, eg. renaming a variable)
test: (adding missing tests, refactoring tests; no production code change)
chore: (updating grunt tasks etc; no production code change)

Please sign in to comment.