Merge pull request #295 from vyshnav-vinod/main

fix: Window now closes when 'x' is clicked
tomlin7 · Apr 23, 2024 · 92a5af4 · 92a5af4
2 parents 83437bd + 5c88a2d
commit 92a5af4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/biscuit/core/commands.py b/biscuit/core/commands.py
@@ -91,7 +91,7 @@ def close_dir(self, *_) -> None:
 
     def quit(self, *_) -> None:
         self.base.on_close_app()
-        self.base.destroy()
+        # self.base.destroy()
 
     def toggle_maximize(self, *_) -> None:
         match platform.system():

diff --git a/biscuit/core/gui.py b/biscuit/core/gui.py
@@ -143,6 +143,7 @@ def register_onfocus(self, fn) -> None:
 
     def on_close_app(self) -> None:
         self.editorsmanager.delete_all_editors()
+        self.destroy()
 
     def on_focus(self, *_) -> None:
         for fn in self.onfocus_callbacks: