Feat/autosave for editor #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 4, 2023 18:31
Before this commit the tests were failling due to an operation inside BreadCrumbs class. When it tries to call `self.addItem` the first element of the list `path` was empty. This caused and error at least at Linux machines because it's empty. This commit fixes the issue by adding `os.path.sep` as a fallback.
Before this commit the saving had to be done manually by the user. This commit adds the autosaving behavior using tkinter method `after` with a default timer of 10 seconds. The feature can be enable/disabled, and the timer changed at config/__init__ file. The saving its done for all the active files.
|
Really clean implementation! I will document the process more so that it will be easy for everyone to read the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature of auto saving the opened files.
Also, it fixes an issue with the BreadCrumbs class when the path is empty (commit:8aa052c)
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #134
Added tests?
Added to documentation?