Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deploy): deploy aarch64-unknown-linux-musl #119

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Aug 27, 2023

Add a binary release of the aarch64-unknown-linux-musl target that is in mdBook but not in this repository.

I have tested this on my fork.

image

The strip command does not work for aarch64 binary on x86_64 machine, so I changed the options on Cargo.toml to set strip.

Copy link
Owner

@tommilligan tommilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - apologies for taking a while to look at it. Just waiting for CI push through then will merge

@tommilligan tommilligan merged commit 95dc758 into tommilligan:main Sep 9, 2023
5 checks passed
@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 9, 2023

Thanks for merging!

@eitsupi eitsupi deleted the add-aarch64-musl branch September 9, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants