Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide extra markers displayed in Safari. #185

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

CoralPink
Copy link
Contributor

Hi!

As far as I know, this seems to be a Safari only phenomenon, but I have noticed that extra ▶︎ is being displayed where I have set collapsible.

```admonish info title="example", collapsible=true
Example
```
before

...so why not add the following code to make this disappear?

:is(.admonition-title, summary.admonition-title) {

//

  &::-webkit-details-marker {
    display: none;
  }

//

}
after

I don't know if this is the right place...
is this the right place? 😅

@tommilligan
Copy link
Owner

Hi, thanks for the report and the contribution - sorry I didn't get round to doing anything about this for so long.

I updated your branch with what I think should be the right place to fix this - I'm not able to test this locally, would you mind testing and seeing if this still fixes it for you?

@CoralPink
Copy link
Contributor Author

Hi, I've tried it locally and it seems to be working as expected!

Result:
display-none

Comment out:
comment-out

However, I'm a little worried because I can't find any documentation for -webkit-details-marker when I looked again...

…I hope it's just that I haven't found it... 🫠

@tommilligan
Copy link
Owner

I found a reference to it here where they suggest exactly what you did in this PR (using display none to hide it), so looks all good to me

@tommilligan tommilligan merged commit 43579f9 into tommilligan:main Aug 17, 2024
6 checks passed
@CoralPink
Copy link
Contributor Author

I see!

Thanks for telling me!😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants