feat: add default title option #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Thanks for the initial pass on this, it's a really good starting point.
I ended up doing a little bit of a wider refactor to make the distinction between AdmonitionInfo (resolved values for rendering) and AdmonitionInfoRaw (raw user configuration) clearer. Probably some new names would help as well.
I also added support for collapsible at the same time, to check the approach was extensible.
I've pushed a commit with my review changes in it - have a look and see if anything sticks out to you. Otherwise I'll push the changes in sometime this week.
tommilligan
force-pushed
the
feat_default-title
branch
from
7388967 to
9ab60da
Compare
|
In testing this looks good to me 👍 |
tommilligan
force-pushed
the
feat_default-title
branch
from
9ab60da to
f606ad8
Compare
|
Now released in v1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Priorities:
explicit > default > directiveWhat this means is any parse-able title given in the codeblock is taken as the desired. Then, any default given in the
book.toml. Then, the directive is used as the fallback.My code is messier than I expected. So, feel free to be nit-picky about it
Specifically, I am not sure how useful the return
Result<()>fromAdmonition::attach_defaultsis.Closes #82