Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement page object pattern in e2e tests #163

Merged
merged 1 commit into from
May 6, 2023
Merged

refactor: implement page object pattern in e2e tests #163

merged 1 commit into from
May 6, 2023

Conversation

tomosterlund
Copy link
Owner

Checklist

Please put "X" in the below checkboxes that apply::

  • If committing a bugfix, I have tested it in different browsers (Chrome, Firefox, Safari).
  • If committing a new feature, I have first submitted an issue (Please note: you are free to open PRs for non-issued features, but opening an issue increases your chance of a successful PR).
  • If committing a new feature, I have also written an appropriate test suite for it.

I have tested the following:

  • Qalendar component in month mode.
  • Qalendar component in week mode.
  • Qalendar component in day mode.
  • All of the above modes on emulated mobile view.
  • Dragging and dropping events.
  • Resizing events in day/week modes.
  • Clicking events to open event dialog.

This PR solves the following problem**.

insert your description.

How to test this PR**.

For example:

  1. Feed X and Y in the events-Prop.
  2. Click Z or A.
  3. Confirm that B is displayed.

@tomosterlund tomosterlund merged commit 3f3e27c into v3 May 6, 2023
@tomosterlund tomosterlund deleted the test/implement_page_object_pattern branch May 6, 2023 09:45
tomosterlund added a commit that referenced this pull request Jun 12, 2023
@tomosterlund @felix-berlin @loicgeek
feat: v3 (#177)
b9ff016 
BREAKING CHANGE: month mode on small screens has a new layout, and monthEvent slot now only works on larger screens

* feat: new month view for mobile (#174)

* feat: flexible day boundaries (#146)

* fix: linting errors

* chore(deps): update vite

* chore: update typescript version

* chore: update import of types to be ts5 compatible

* refactor: implement page object pattern in e2e tests (#163)

Co-authored-by: Felix Scholze <felix@webshaped.de>
Co-authored-by: loic <loic.ngou98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomosterlund