Fix usage of response_types_map inside API client's call_api method.
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 28.70% 28.70%
=======================================
Files 725 725
Lines 86624 86626 +2
=======================================
+ Hits 24864 24866 +2
Misses 61760 61760 ☔ View full report in Codecov by Sentry. |
|
LGTM, but i can't merge it as is a "draft". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
I didn't add tests because I couldn't see any existing tests for the
call_apimethod, but if I missed it, please let me know.I accidentally didn't read the contribution guidelines before creating this, I'll leave this in draft until the issue has been validated / accepted.